me/pi-ku
me/pi-ku
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: fail CI on lint and format issues instead of silently rewriting them #20

Merged
me merged 1 commit from fix/biome-ci-fails-on-drift into perf/ci-faster-installs 2026-08-29 15:01:58 +00:00
Conversation 0 Commits 1 Files changed 3 +7 -2
me commented 2026-08-29 15:00:50 +00:00
Owner
Copy link

The frontend job's Code Quality step ran 'bun run check', which is 'biome check --write ./src'. In CI that is a no-op gate: it rewrites offending files in the runner's working copy and exits 0, so formatting problems and auto-fixable lint issues pass silently and never reach anyone. The rewrites are then discarded with the runner.

Fix: add a 'check:ci' script running 'biome ci ./src' (biome's CI-intended command: reports, never writes, exits non-zero) and point both workflows' Code Quality step at it. The local 'check' script keeps its --write behaviour, which is what you want at a developer's keyboard.

Verified: 'biome ci ./src' exits 0 on the current tree (no pre-existing drift to clean up); with a deliberately misformatted file added, 'bun run check:ci' exits 1 and leaves the file untouched, while the old 'biome check --write' exits 0 and rewrites it - reproducing the bug exactly. Build and unit tests still pass (68/68).

Stacked on #19 and targets that branch, since both PRs edit the same frontend-job region; retarget to main once #19 merges.

The frontend job's Code Quality step ran 'bun run check', which is 'biome check --write ./src'. In CI that is a no-op gate: it rewrites offending files in the runner's working copy and exits 0, so formatting problems and auto-fixable lint issues pass silently and never reach anyone. The rewrites are then discarded with the runner. Fix: add a 'check:ci' script running 'biome ci ./src' (biome's CI-intended command: reports, never writes, exits non-zero) and point both workflows' Code Quality step at it. The local 'check' script keeps its --write behaviour, which is what you want at a developer's keyboard. Verified: 'biome ci ./src' exits 0 on the current tree (no pre-existing drift to clean up); with a deliberately misformatted file added, 'bun run check:ci' exits 1 and leaves the file untouched, while the old 'biome check --write' exits 0 and rewrites it - reproducing the bug exactly. Build and unit tests still pass (68/68). Stacked on #19 and targets that branch, since both PRs edit the same frontend-job region; retarget to main once #19 merges.
me merged commit 1e66e20573 into perf/ci-faster-installs 2026-08-29 15:01:58 +00:00
me deleted branch fix/biome-ci-fails-on-drift 2026-08-29 15:01:58 +00:00
me referenced this pull request from a commit 2026-08-29 15:01:59 +00:00
fix(ci): fail CI on lint and format issues
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
me/pi-ku!20
No description provided.