feat: make the app observable #28

Open

me wants to merge 6 commits from feature/observability into main

pull from: feature/observability

merge into: me:main

me:main

Conversation 0 Commits 6 Files changed 21 +477 -99

me commented 2026-08-31 07:45:12 +00:00

Owner

Copy link

json.log had 1,248 lines in it and exactly two distinct events: request_started and request_finished. Nothing the app actually does was ever logged — three logger calls in the whole backend, none in the frontend.

This fixes twelve findings from an audit of that. The author's email is no longer f-stringed into vault notification logs. Login failures get logged instead of vanishing into a bare except, so a wrong password and a dead database no longer look identical. Config nothing used is gone: letters.log had been 0 bytes since it was created, flat_line.log was a copy of json.log, django.core.mail at DEBUG was silent. Requests now carry a duration and an X-Request-ID the frontend displays, so a bug report can be traced to a log line. The frontend gets a reporter, an ErrorBoundary and global handlers, having previously had nowhere to put an error except the reader's screen. And /api/health/ exists, with the compose healthchecks switched back on.

Backend 25 tests, frontend 81, ruff/biome/tsc clean. Also checked against a running server, not just in tests.

Five findings are left out because they need a decision rather than a patch: the log event names belong in CONTEXT.md first, IP logging deserves an ADR, and the log files still don't rotate or survive a redeploy. Tickets are in .scratch/observability/.

Audit: https://claude.ai/code/artifact/8dc7cf3b-dc1e-4b2c-91cc-f4b87b6d9aeb

`json.log` had 1,248 lines in it and exactly two distinct events: `request_started` and `request_finished`. Nothing the app actually does was ever logged — three logger calls in the whole backend, none in the frontend. This fixes twelve findings from an audit of that. The author's email is no longer f-stringed into vault notification logs. Login failures get logged instead of vanishing into a bare `except`, so a wrong password and a dead database no longer look identical. Config nothing used is gone: `letters.log` had been 0 bytes since it was created, `flat_line.log` was a copy of `json.log`, `django.core.mail` at DEBUG was silent. Requests now carry a duration and an `X-Request-ID` the frontend displays, so a bug report can be traced to a log line. The frontend gets a reporter, an ErrorBoundary and global handlers, having previously had nowhere to put an error except the reader's screen. And `/api/health/` exists, with the compose healthchecks switched back on. Backend 25 tests, frontend 81, ruff/biome/tsc clean. Also checked against a running server, not just in tests. Five findings are left out because they need a decision rather than a patch: the log event names belong in `CONTEXT.md` first, IP logging deserves an ADR, and the log files still don't rotate or survive a redeploy. Tickets are in `.scratch/observability/`. Audit: https://claude.ai/code/artifact/8dc7cf3b-dc1e-4b2c-91cc-f4b87b6d9aeb

me added 10 commits 2026-08-31 07:45:12 +00:00

fix: unfold the letter out of the envelope without a mid-reveal jag 57d2452721

fix: keep the author's send and burn actions reachable while the letter is sealed 561e9a28e6

fix: let the reader fill the app shell so no background bands show above and below 02dcca469c

fix: pin the author's actions to the bottom so they never jump when the letter opens 3bc61d2a0d

fix: log vault notifications as structured events without the author's email 26dd8ca934

fix: log authentication failures instead of swallowing them silently 53562b3aad

refactor: drop logging config and gunicorn flags that nothing uses df1bf16472

feat: add request duration and an X-Request-ID response header 98fb0a9333

feat: add a health endpoint and re-enable the container healthchecks ebabe2cf8c

feat: give the frontend an error reporter instead of showing readers a stack 263f6744a1

me force-pushed feature/observability from 263f6744a1 to 91779ab7a5 2026-08-31 07:49:55 +00:00 Compare

me force-pushed feature/observability from 91779ab7a5 to 5859fb3751 2026-08-31 11:04:33 +00:00 Compare

All checks were successful

Hide all checks

CI / Frontend CI (pull_request) Successful in 3m24s

Details

CI / Backend CI (pull_request) Successful in 53s

Details

CI / E2E Tests (pull_request) Successful in 5m33s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/observability:feature/observability

git switch feature/observability

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff feature/observability

git switch feature/observability

git rebase main

git switch main

git merge --ff-only feature/observability

git switch feature/observability

git rebase main

git switch main

git merge --no-ff feature/observability

git switch main

git merge --squash feature/observability

git switch main

git merge --ff-only feature/observability

git switch main

git merge feature/observability

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

me/pi-ku!28

No description provided.